Skip to content

Allow to show internal buffers only if unread#2105

Open
luca020400 wants to merge 3 commits into
squidowl:mainfrom
luca020400:luca/unread_buf
Open

Allow to show internal buffers only if unread#2105
luca020400 wants to merge 3 commits into
squidowl:mainfrom
luca020400:luca/unread_buf

Conversation

@luca020400

Copy link
Copy Markdown
Contributor

No description provided.

@andymandias

Copy link
Copy Markdown
Collaborator

We have received a request for similar functionality on regular buffers (#1132). While we do not need to add that functionality in this PR, I do think it is worth considering a bit in the hopes of crafting a UX that can be used in both cases. For muting channels/queries I suspect we'd want to do so by name (e.g. "mute = [ "#halloy", "#libera" ]" in the server configuration), or a global configuration that uses Inclusivities. A similar UX could be adopted here, in which case internal buffers that do not have an unread state would be invalid entries for the setting (providing feedback at time of setting whether the setting will work how they hope it does).

@luca020400

Copy link
Copy Markdown
Contributor Author

We have received a request for similar functionality on regular buffers (#1132). While we do not need to add that functionality in this PR, I do think it is worth considering a bit in the hopes of crafting a UX that can be used in both cases. For muting channels/queries I suspect we'd want to do so by name (e.g. "mute = [ "#halloy", "#libera" ]" in the server configuration), or a global configuration that uses Inclusivities. A similar UX could be adopted here, in which case internal buffers that do not have an unread state would be invalid entries for the setting (providing feedback at time of setting whether the setting will work how they hope it does).

I think it would be a great UX addition, may work on it in the future ^^

@casperstorm

Copy link
Copy Markdown
Member

Hmm, one small thing is that with this you could end up in a situtation where logs is gone, without the user is able to open it from either sidebar or menu.

@luca020400

Copy link
Copy Markdown
Contributor Author

Hmm, one small thing is that with this you could end up in a situtation where logs is gone, without the user is able to open it from either sidebar or menu.

Yeah that's possible, this PR was made a bit before #2110 was uploaded so I didn't really take into account that scenario.
With that said I think it may get rather messy to add yet another piece of logic tied to history for the menu, up to you ^^

@andymandias

Copy link
Copy Markdown
Collaborator

I believe what Discord does is have a menu entry (somewhere) to show/hide muted channels. Perhaps we could add something like that to the sidebar menu and/or command bar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants