Skip to content

chore: build as cjs package #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyyynthia merged 3 commits into from
May 15, 2024
Merged

chore: build as cjs package #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3d3bdc
chore: build as cjs package
cyyynthia May 11, 2024
7fce80d
chore: doc update, semver minor
cyyynthia May 15, 2024
acfd65b
chore: fix package repository field
cyyynthia May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "smol-toml",
"version": "1.1.4",
"version": "1.1.5",
Copy link
Copy Markdown

@DavidAnson DavidAnson May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the risk of being a pest, I think changing the primary export from ESM to CJS should be considered a breaking change (i.e., semver major increment vs. patch increment).

Copy link
Copy Markdown
Member Author

@cyyynthia cyyynthia May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why that'd be the case; but the change shouldn't have any effect on downstream users (the package remains compatible with ESM-style imports) so I'm unsure if a semver major is necessary here 🤔

Copy link
Copy Markdown

@DavidAnson DavidAnson May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! I hadn't realized existing uses would continue to work, sorry.

"keywords": [
"toml",
"parser",
Expand All @@ -10,10 +10,9 @@
"repository": "git@github.com:squirrelchat/smol-toml.git",
"author": "Cynthia <cyyynthia@borkenware.com>",
"license": "BSD-3-Clause",
"type": "module",
"engines": {
"node": ">= 18",
"pnpm": ">= 8"
"pnpm": ">= 9"
},
"scripts": {
"build": "tsc",
Expand All @@ -24,13 +23,13 @@
"devDependencies": {
"@iarna/toml": "3.0.0",
"@ltd/j-toml": "^1.38.0",
"@tsconfig/node-lts": "^20.1.1",
"@tsconfig/strictest": "^2.0.2",
"@types/node": "^20.11.5",
"@vitest/ui": "^1.2.1",
"@tsconfig/node-lts": "^20.1.3",
"@tsconfig/strictest": "^2.0.5",
"@types/node": "^20.12.11",
"@vitest/ui": "^1.6.0",
"fast-toml": "^0.5.4",
"typescript": "^5.3.3",
"vitest": "^1.2.1"
"typescript": "^5.4.5",
"vitest": "^1.6.0"
},
"exports": {
".": {
Expand Down
Loading