Fixes Non Traditional Spacing Errors during parsing.#8
Merged
cyyynthia merged 6 commits intosquirrelchat:mistressfrom Oct 17, 2023
wyatt-herkamp:non-traditional-spacing
Merged
Fixes Non Traditional Spacing Errors during parsing.#8cyyynthia merged 6 commits intosquirrelchat:mistressfrom wyatt-herkamp:non-traditional-spacing
cyyynthia merged 6 commits intosquirrelchat:mistressfrom
wyatt-herkamp:non-traditional-spacing
Conversation
cyyynthia
requested changes
Oct 17, 2023
Member
cyyynthia
left a comment
cyyynthia
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR, and HUGE THANKS for adding tests!!! I'm surprised this wasn't caught by the toml-test suite, it might be a good contribution to the test suite as well.
I only have a few formatting nitpicks and remarks on the tsconfig changes. Great work! ❤️
cyyynthia
approved these changes
Oct 17, 2023
Member
|
Huge thanks! I'll publish the updated version later today or tomorrow morning (CEST). ❤️ I'll post a comment here when it is published. |
Member
|
This has now been published as v1.1.3. Thanks again for the contribution! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Swatinem/rust-cache#167
This also updates the dependencies.