Possible fix for #1671 #1686
Possible fix for #1671 #1686
Conversation
fix for squizlabs#1671 should not break alias but also should fix IDE problems at least phpStorm works. lets see if tests pass
|
okay, PHP_CodeSniffer is not happy about this workaround but maybe we could ignore this or implement in PHP_CodeSniffer friendly way? Anyway is this good way to fix this? |
|
Also if we don't want to fix this then maybe we can inverse this and create aliases, not for new phpunit versions but for old then only people with legacy versions will have problems lets hope there are fewer people |
It's been set up so that it will be easy to drop support for older PHPUnit versions when the time comes. Inversing the aliases breaks that. |
|
@jrfnl don't know how this would be more difficult to drop support older versions but maybe don't know everything. Then what about this workaround of a workaround? :) |
For what it's worth: IMHO this is a shortcoming/issue with the IDE and not something which should be solved in PHPCS. |
|
I understand that this is not a phpcs problem but this issue is really annoying also easy to fix and don't expect this to be fixed in all IDE's soon. But I am +1 to adding tests to .gitattributes. |
|
I've merged this in. Is anyone able to test and see if it is working. Before anyone decides to comment, I'm aware this is a hacky fix. I really don't have the time to put effort into something like this. As long as it works, I'm happy for now. |
|
dev-master no longer shows duplicate implementations so works for me. But That's my PR so guess this doesn't count... |
If you're the only one who confirms it, it counts a lot! Thanks for testing. |
|
Confirmed a second time on main report. |
3 participants
fix for #1671 should not break alias but also should fix IDE problems at least phpStorm works. lets see if tests pass