Generic/DisallowLongArray: fix undefined index when running fixer #1708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Came across this error when running fixer conflict checks for the various standards. Error encountered: `Undefined index: in phpcs/src/Fixer.php on line 524` Error occurred when due to, for instance, a git merge conflict artifact, the array closer has not been determined. Includes unit tests. To reproduce/test: take the updated unit test file and just run the original sniff over it.
|
Rebased for merge conflicts & updated code style... |
jrfnl
force-pushed
the
feature/fix-generic-disallow-longarray
branch
from
ed2f11f to
8d2a9dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this error when running fixer conflict checks for the various standards. (See #1645 (comment) )
Third fix in a series to fix the issues found.
Error encountered:
Undefined index: in phpcs/src/Fixer.php on line 524Error occurred when due to, for instance, a git merge conflict artifact, the array closer has not been determined.
Includes unit tests.
One of the already existing unit tests results has been adjusted. a found
arraykeyword without parentheses was previously being fixed to short array syntax.However, as this is "unfinished" code, it could just as easily have been the start of an array function call like
array_merge(), making this a risky fix.For this case as well as the new case, the error will still be reported, but the fixer will no longer run for these.
To reproduce/test: take the updated unit test file and just run the original sniff over it.