PEAR/FunctionDeclaration: fix undefined offset error #1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a JS function declared at the very top of the file, there may not be a token on a previous line. Always moving the pointer one forward at the end of the loop prevents an `undefined offset -1` error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this error when running fixer conflict checks for the various standards. (See #1645 (comment) )
Sixth fix in a series to fix the issues found.
For a JS function declared at the very top of the file, there may not be a token on a previous line.
Always moving the pointer one forward at the end of the loop prevents an
undefined offset -1error.To reproduce the issue, run:
phpcbf -p -s --standard=Squiz ./src/Standards/Squiz/Tests/Functions/MultiLineFunctionDeclarationUnitTest.js -vv