Generic/MultipleStatementAlignment: fix fatal error #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased for merge conflicts & updated code style... |
jrfnl
force-pushed
the
feature/fix-generic-multistatementalign-fixer-fatal
branch
from
c87c3c2 to
fb90c4f
Compare
In certain cases, it was possible for the `$expected` padding to become less than zero, leading to the following fatal error during fixing: `str_repeat(): Second argument has to be greater than or equal to 0 in phpcs/src/Standards/Generic/Sniffs/Formatting/MultipleStatementAlignmentSniff.php on line 293` This PR fixes that. Includes unit tests.
jrfnl
force-pushed
the
feature/fix-generic-multistatementalign-fixer-fatal
branch
from
fb90c4f to
a69c478
Compare
jrfnl
deleted the
feature/fix-generic-multistatementalign-fixer-fatal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this error when running fixer conflict checks for the various standards. (See #1645 (comment) )
Eighth fix in a series to fix the issues found.
In certain cases, it was possible for the
$expectedpadding to become less than zero, leading to the following fatal error during fixing:str_repeat(): Second argument has to be greater than or equal to 0 in phpcs/src/Standards/Generic/Sniffs/Formatting/MultipleStatementAlignmentSniff.php on line 293This PR fixes that.
Includes unit tests.