PEAR/ScopeClosingBrace: fix fixer conflict

[jrfnl]

Another small PR to fix a fixer conflict between the PEAR.WhiteSpace.ScopeClosingBrace and the PEAR.WhiteSpace.ScopeIndent (extended from Generic.WhiteSpace.ScopeIndent) sniffs.

If a case or default statement uses braces, the scope indent and scope closing brace sniffs would fight over where the brace should be placed.

The unit test file already contains a test case highlighting the issue.

PHP_CodeSniffer/src/Standards/PEAR/Tests/WhiteSpace/ScopeClosingBraceUnitTest.inc

Lines 88 to 90 in b55fd82

	switch($i) {
	case 1: {}
	}

To reproduce the issue, run the following command on the master branch:
phpcbf -p -s -vv ./src/Standards/PEAR/Tests/WhiteSpace/ScopeClosingBraceUnitTest.inc --standard=PEAR

Note: this change does change the behaviour of the sniff in that particular case. If that's undesired, another solution will need to be found.

[gsherwood]

I don't like the change of behaviour for PEAR.WhiteSpace.ScopeClosingBrace.BreakIndent with this, but there is a clear conflict here.

I think the only way to fix this is figure out how to change PEAR.WhiteSpace.ScopeIndent to not report errors for the closing brace of CASE and DEFAULT statements. But I don't really want to do that with a new sniff property because it's pretty specific, so that might mean (finally) refactoring the main scope indent sniff so that some of it can be overridden in the PEAR sniff.

[jrfnl]

that might mean (finally) refactoring the main scope indent sniff so that some of it can be overridden in the PEAR sniff.

@gsherwood Yes, that's one I haven't dared to touch yet, but I'm seeing more conflicts which involve that sniff. I still need to find the time to dig in deeper to come up with good test cases though.
Will report back when I have.