Squiz/CommentedOutCode: fix false positive + false negative #2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation Updated the regex used to detect annotations from other tools to also allow for PHPMD suppression annotations. This gets rid of the false positive on unit test case file line 138. Depending on end-user reports, the regex can be improved further.
After the changes I made in PR 1839, this unit test case now added was incorrectly no longer recognized as commented out code. This PR further iterates on the previous changes: * Treat a line comment followed by a block comment (and visa versa) as two separate comments. * Allow for blank lines within block comments, but not within line comment blocks.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squiz/CommentedOutCode: fix false positive for PHPMD suppression annotation
Updated the regex used to detect annotations from other tools, to also allow for PHPMD suppression annotations.
This gets rid of the false positive on unit test case file line 138.
Depending on end-user reports, the regex can be improved further.
Squiz/CommentedOutCode: fix false negative
After the changes I made in PR #1839, this code now added to the unit test case file was incorrectly no longer recognized as commented out code.
This PR further iterates on the previous changes and implements the following: