object.Tree.FindEntry should return ErrFileNotFound rather than errEntryNotFound

[jsravn]

If directory is not found, it will return the public error ErrDirNotFound. For a missing file, it returns errEntryNotFound:

go-git/plumbing/object/tree.go

Line 178 in f019589

return nil, errEntryNotFound

Since the error is private there isn't a way to programmatically check for that condition.

[smola]

@jsravn Note that an entry can be a directory, file, symlink or submodule. So ErrDirNotFound would not be correct in every situation.

[jsravn]

@jsravn Note that an entry can be a directory, file, symlink or submodule. So ErrDirNotFound would not be correct in every situation.

What would you suggest for my usecase then: programmatically determining the entry is not found? Currently tree.go only exposes the errors:

// New errors defined by this package.
var (
	ErrMaxTreeDepth      = errors.New("maximum tree depth exceeded")
	ErrFileNotFound      = errors.New("file not found")
	ErrDirectoryNotFound = errors.New("directory not found")
)

And FindEntry returns ErrDirNotFound already if it's a tree entry that's missing. Would it make more sense to expose ErrEntryNotFound as public?

[smola]

@jsravn Yes. Making ErrEntryNotFound public would be more sensible.

[jsravn]

@smola Okay, I've updated my PR.

[jsravn]

#885