Conversation
smacker
approved these changes
Oct 26, 2018
Contributor
smacker
left a comment
smacker
left a comment
There was a problem hiding this comment.
Does it require any new env vars in travis?
Contributor
Author
|
@smacker it does, I have added them already as secrets |
rporres
suggested changes
Oct 26, 2018
.travis.yml
Outdated
| - name: 'Deploy to staging' | ||
| stage: release | ||
| script: | ||
| - HELM_RELEASE=lookout-gometalint-analyzer HELM_CHART=src-d/lookout-gometalint-analyzer K8S_NAMESPACE=lookout HELM_ARGS="--tiller-namespace=lookout --set image.tag=$TRAVIS_TAG -f .helm_staging.yml" make deploy |
There was a problem hiding this comment.
I don't think this is going to work as we need the repo url. HELM_CHART should we set to lookout-gometalint-analyzer and we should add --repo https://src-d.github.io/charts/index.yaml
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
rporres
approved these changes
Oct 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maartje Eyskens maartje@eyskens.me