Merged
Conversation
dpordomingo
approved these changes
Dec 4, 2018
smacker
approved these changes
Dec 4, 2018
dpordomingo
suggested changes
Dec 26, 2018
Contributor
dpordomingo
left a comment
dpordomingo
left a comment
There was a problem hiding this comment.
The proposed change in src-d/go-log#9 was not accepted, so this PR should be reviewd, shouldn't it?
Contributor
Author
|
Yes, I created #427 to make the needed changes. |
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Contributor
Author
|
Pushed again using the changes from #439. |
smacker
approved these changes
Jan 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #357.
WIP because it depends on src-d/go-log#9.
I checked that if an old queue job without the field in this PR is dequeued and deserialized, it works without a problem.
I changed the fields added by the github provider because
pr-numberdoes not really help to identify, and adds noise. I also added agithub.prefix to help organize log fields a bit better, the same way we havegrpc.start_time,grpc.code.