Skip to content

Remove unnecessary named import#510

Merged
dpordomingo merged 1 commit intosrc-d:masterfrom
dpordomingo:fix-named-import
Feb 8, 2019
Merged

Remove unnecessary named import#510
dpordomingo merged 1 commit intosrc-d:masterfrom
dpordomingo:fix-named-import

Conversation

@dpordomingo
Copy link
Copy Markdown
Contributor

@dpordomingo dpordomingo commented Feb 8, 2019

caused by golang/go#29556

Otherwise, Travis fails.
https://travis-ci.org/src-d/lookout/builds/490419439#L834

I was introduced by an old version of golang.org/x/tools, that must be locally updated in order to generate proper kallax code.

More details at breaking commit golang/tools@cb89afa

@dpordomingo dpordomingo added the bug Something isn't working label Feb 8, 2019
@dpordomingo dpordomingo self-assigned this Feb 8, 2019
Caused by golang/tools@cb89afa

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo dpordomingo merged commit e125775 into src-d:master Feb 8, 2019
@dpordomingo dpordomingo deleted the fix-named-import branch February 8, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants