Skip to content

Add integration tests for analyzing a PR from a fork#570

Merged
dpordomingo merged 2 commits intosrc-d:masterfrom
dpordomingo:from-PR
Feb 28, 2019
Merged

Add integration tests for analyzing a PR from a fork#570
dpordomingo merged 2 commits intosrc-d:masterfrom
dpordomingo:from-PR

Conversation

@dpordomingo
Copy link
Copy Markdown
Contributor

fix #232
fixtures from src-d/lookout-test-fixtures#26
blocked by src-d/lookout-test-fixtures#27

This PR add integration tests for analyzing a PR from a fork

@dpordomingo dpordomingo added enhancement New feature or request enhance-tests This will improve the app testing labels Feb 27, 2019
@dpordomingo dpordomingo self-assigned this Feb 27, 2019
@dpordomingo
Copy link
Copy Markdown
Contributor Author

@smacker I added you as a reviewer because you created #232
Let me know if this PR address your requirements 🗡️

@dpordomingo
Copy link
Copy Markdown
Contributor Author

Travis fails because src-d/lookout-test-fixtures#27 dependency

Copy link
Copy Markdown
Contributor

@smacker smacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most probably I meant that fixture to be used in github integration tests (which we don't have yet) but this one works as well for now. thanks!

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo dpordomingo merged commit 75f3ff0 into src-d:master Feb 28, 2019
@dpordomingo dpordomingo deleted the from-PR branch February 28, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhance-tests This will improve the app testing enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add fixture with changes from fork

3 participants