Implement Deadline for strategies #27
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with
$STRATEGY.take(n)
is that is doesn't take function execution time into consideration. If you use a strategy that retries 100 times, every 10 milliseconds, but you use it against a function that takes 1 second to execute, the total execution time will be 101 seconds (100 * (fn execution + retry interval) = 100 * (1 + 0.01)
).In this PR I'm adding a
deadline(max_duration)
function, which restricts how much time can a strategy take. It usesInstant
clock to count the time since the strategy was created, so it includes the function execution time.Please tell me what you think.