Skip to content

WIP: Run tests both on Windows & Linux #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

WIP: Run tests both on Windows & Linux #1187

wants to merge 6 commits into from

Conversation

dimhotepus
Copy link
Contributor

@dimhotepus dimhotepus commented Sep 26, 2023 •
edited
Loading

  • Run tests both on Windows and Linux hosts.

@dimhotepus dimhotepus changed the title Run tests both on Windows & Linux WIP: Run tests both on Windows & Linux Sep 26, 2023
@Rob-Hague
Copy link
Collaborator

Nice.

Could you please keep it in Debug mode? There are a number of Debug.Assert calls that we would want to fire if they were hit.

Could you also try to run the integration tests? I believe the appveyor images have docker installed. I have been wondering if just dotnet test src/Renci.SshNet.sln is all that is needed (or if appveyor would even do that automatically without the command)

@WojciechNagorski
Copy link
Collaborator

@dimhotepus Thanks! Great work. I will use this PR.

@Rob-Hague Rob-Hague mentioned this pull request Oct 21, 2023
Closed
@WojciechNagorski
Copy link
Collaborator

I will continue this work on #1250
Big thenks @dimhotepus

@dimhotepus dimhotepus deleted the ubuntu-ci branch November 25, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimhotepus @Rob-Hague @WojciechNagorski