Add an OrderedDictionary implementation for algorithm priorities #1611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the key exchange, the algorithms to be used are chosen based on the order that the client sends: first algorithm is most desirable. Currently, the algorithm collections in ConnectionInfo are defined as IDictionary<,> and backed by Dictionary<,>, which does not have any guarantees on the order of enumeration (in practice, when only adding and not removing items it does enumerate in the order that items were added as an implementation detail, but it's not great to rely on it). This change adds IOrderedDictionary<,> and uses it in ConnectionInfo. On .NET 9, this is backed by System.Collections.Generic.OrderedDictionary<,> and on lower targets, it uses a relatively simple implementation backed by a List and a Dictionary.
WojciechNagorski
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the key exchange, the algorithms to be used are chosen based on the order that the client sends: first algorithm is most desirable. Currently, the algorithm collections in
ConnectionInfoare defined asIDictionary<,>and backed byDictionary<,>, which does not have any guarantees on the order of enumeration (in practice, when only adding and not removing items it does enumerate in the order that items were added as an implementation detail, but it's not great to rely on it).This change adds
IOrderedDictionary<,>and uses it inConnectionInfo. On .NET 9, this is backed bySystem.Collections.Generic.OrderedDictionary<,>and on lower targets, it uses a relatively simple implementation backed by a List and a Dictionary.For example, to prioritise zlib compression over the default "none" compression:
closes #683
closes #719