Skip to content

Only enable TreatWarningsAsErrors in Release #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2025
Merged

Only enable TreatWarningsAsErrors in Release #1624

merged 3 commits into from
Mar 29, 2025

Conversation

mus65
Copy link
Contributor

@mus65 mus65 commented Mar 29, 2025

Having this enabled in Debug is imho annoying for multiple reasons:

  • sometimes you just want to temporarily add code for debugging and don't want to deal with the errors.
  • when a .NET SDK major version introduces new analyzers, you can't build anymore. I e.g. currently can't build just because I have .NET 10 Preview installed.
  • In other projects I haven seen even minor SDK versions introduce new warnings because there were bugfixes in existing analyzers. So you suddenly can't build because of a .NET SDK minor update.

Rob-Hague
Rob-Hague reviewed Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@Rob-Hague
Copy link
Collaborator

on the topic of SDKs, I think our global.json isn't doing anything right now. We could delete it or add "allowPrerelease": false

mus65 and others added 2 commits March 29, 2025 16:17
@mus65
Remove global.json
3099c5f 
this doesn't actually do anything useful like this.
@mus65 @Rob-Hague
Also check CI
db86d72 
Co-authored-by: Rob Hague <[email protected]>
@Rob-Hague Rob-Hague merged commit 02c30c8 into sshnet:develop Mar 29, 2025
4 checks passed
@Rob-Hague Rob-Hague mentioned this pull request Apr 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob-Hague Rob-Hague Rob-Hague approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mus65 @Rob-Hague