Remove unused bcrypt password hashing code #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mus65
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
Rob-Hague
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1482 .
The BCrypt code was originally ported from the sshj implementation which in turn seems to originate from mindrot jBCrypt .
The code currently also contains the BCrypt password hashing functionality which isn't actually used by SSH.NET . This PR reduces the code to the necessary pbkdf functionality. sshj did a similiar cleanup, so this PR actually brings it closer the original source again.
Regarding #1482 : I don't think the pbkdf functionality can be replaced by BouncyCastle, since it only seems to contain APIs for the password hashing functionality. Maybe the blowfish hashing part could be replaced by BouncyCastle (but I'm not familiar enough with cryptography to actually try this).