Replace Queue<byte> based buffer by array based buffer in PipeStream. #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you seen this lead to improvements in overall download speed? I've been using SftpClient.DownloadFile and have been getting about 28 Mbps (3.5 MB/s), vs 100 Mbps using the scp command line. I'm wondering if this could help. EDIT: Updated to 2016.1.0 and that got me up to 66 Mbps. |
No, the SftpClient does not use the PipeStream at all. Only SshClient and ScpClient use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the rather slow Queue based PipeStream by an array based one. The new PipeStream uses a fixed size array as ring buffer instead of a size limited queue. The default buffer size is 1 MiB. Apart from that it's a drop-in replacement for the current PipeStream.
The array based PipeStream is quite a bit faster than the current one. On my machine (Core i7 4790) in a single-producer/single-consumer scenario I can read and write over 6 GB / second. The current PipeStream's speed is about 65 MB / second.