WIP: Support for Ed25519 Host- and Private-Keys #492
Conversation
|
Wow, this is really nice. You are farther ahead than I was. I think the only area where I have something you don't is I've got the code to decrypt the private key inside the openssh key. Perhaps I could somehow contribute this code to your effort, though I'm honestly not really sure the easiest way to do that in github (commit to your fork?). Regardless I'll spent some time cleaning up the code I had and then I'll commit it to my fork and share the link. I had wanted to use SSH.NET in a work project about a year ago but the lack of ED25519 support was a showstopper so we had to do something else (wrote a C# wrapper around libssh) but I always wanted to come back and contribute to this project, I finally got around to working on it and it appears you had the same idea! |
darinkes
force-pushed
the
ed25519
branch
2 times, most recently
from
b5e1f43 to
3e29a80
Compare
That would be a huge help! Then I can start working on improving the KEX-Situation, too. |
Also known as:
- ecdsa-sha2-nistp256
- ecdsa-sha2-nistp384
- ecdsa-sha2-nistp521
Works for .NET 3.5 and 4.0 but needs some more testing and tests.
Basically it translate between SSH-Data and Microsoft Crypto API.
Tested with ECDSA-{256,384,521} Hostkeys and ECDSA-{256,384,521}-Pub/Private-Keys
against OpenSSH_7.2p2 Ubuntu-4ubuntu2.4, OpenSSL 1.0.2g 1 Mar 2016.
Keys generated with:
- ssh-keygen -t ecdsa
- ssh-keygen -t ecdsa -b 384
- ssh-keygen -t ecdsa -b 521
ToDo: OpenSSHKey-Reader needs crypto support
|
@darinkes Here is what I had so far, it is only lightly tested however (only walked through a couple unit tests to see if the key parsing works). Let me know what you think, thanks! |
|
@bhalbright Thanks a lot! I will check it out ASAP. |
|
@darinkes I don't know if you've had a chance to look at my fork yet but if you prefer maybe you could make me a contributor on your fork and I could update your impl with the decryption code. I like how you separated the parsing into a separate class anyhow. No rush though, thanks. |
|
@bhalbright I have to do some rework of my approach on EC in SSH.NET. So I'm now checking out other ways to add EC to SSH.NET. It will take some more time. |
|
@bhalbright I cherry-picked your OpenSSH Key-Format Reader into my branch: So it's visible you did the work! 👍 |
|
Closing in favor of: #496 |
|
thanks @darinkes glad I could help out a little! |
|
You have no idea how happy this PR makes me! It has been something I keep having people ask me for to add to posh-ssh for a good time now
…Sent from my iPhone
On Dec 3, 2018, at 9:10 AM, bhalbright ***@***.***> wrote:
thanks @darinkes glad I could help out a little!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks that this was implemented. It has just saved our 2 day bug . We had generated our keys using rsa but we used ssh-ed25519 and now the keys work on our sftp operation. Thanks. Cool stuff |
No description provided.