Skip to content

🐛 AsyncResult contains invalid value (Fix #329) #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🐛 AsyncResult contains invalid value (Fix #329) #680

wants to merge 1 commit into from

Conversation

miroslavpokorny
Copy link
Contributor

  • AsyncResult should contain invalid value immediately after the async operation is marked as completed
  • there were race condition problems with a callback method which is invoked on a different thread so updating of value is done without any synchronization. So in some cases, the async operation is marked as completed but async result value is not yet updated and contains an invalid value

#329

@miroslavpokorny
🐛 AsyncResult contains invalid value
936bb42 
- AsyncResult should contain invalid value immediately after async operation is marked as completed
- there was race condition problems with callback method which is invoked on different thread so updating of value is done without any synchronization. So in some cases async operation is marked as completed but async result value is not yet updated and contains invalid value
@miroslavpokorny miroslavpokorny changed the title 🐛 AsyncResult contains invalid value 🐛 AsyncResult contains invalid value (Fix #329) May 21, 2020
@roewer
Copy link

roewer commented Jun 10, 2021

Looks like this fixed has not been merged into develop yet. The problem still exists in the current 2020.0.1 release. Can this fix get released?

@WojciechNagorski
Copy link
Collaborator

@miroslavpokorny PR needs refreshing.

@Rob-Hague Rob-Hague mentioned this pull request Sep 24, 2023
Merged
@Rob-Hague
Copy link
Collaborator

Thanks @miroslavpokorny, this was rebased and merged in #1184 (you are a co-author on that PR).

@Rob-Hague Rob-Hague closed this Dec 4, 2023
@WojciechNagorski WojciechNagorski added this to the 2023.0.1 milestone Dec 4, 2023
@WojciechNagorski
Copy link
Collaborator

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@miroslavpokorny @roewer @WojciechNagorski @Rob-Hague