Start MessageListener with ThreadAbstraction.ExecuteThreadLongRunning #901
Conversation
| @@ -36,16 +29,10 @@ public static void ExecuteThreadLongRunning(Action action) | |||
| /// <param name="action">The action to execute.</param> | |||
| public static void ExecuteThread(Action action) | |||
| { | |||
| #if FEATURE_THREAD_THREADPOOL | |||
There was a problem hiding this comment.
I'm afraid you'll need to revert these changes. ThreadPool is not available for UAP10.0 TFM (see https://github.com/sshnet/SSH.NET/wiki/Conditional-compilation-symbols for more information).
| } | ||
|
|
||
| public static void ExecuteThreadLongRunning(Action action) | ||
| { | ||
| #if FEATURE_THREAD_TAP |
There was a problem hiding this comment.
I propose to leave this as is. Eventually, we'll need to change this as we need the thread or task that we started for our message listener in order to avoid thread leaks (there's an issue for this).
| @@ -10,24 +10,17 @@ internal static class ThreadAbstraction | |||
| /// <param name="millisecondsTimeout">The number of milliseconds for which the thread is suspended.</param> | |||
| public static void Sleep(int millisecondsTimeout) | |||
| { | |||
| #if FEATURE_THREAD_SLEEP | |||
There was a problem hiding this comment.
I'm afraid you'll need to revert these changes. Thread.Sleep(...) is not available for UAP10.0 TFM (see https://github.com/sshnet/SSH.NET/wiki/Conditional-compilation-symbols for more information).
|
Sorry, I've made an error to "Fetch upstream" from GitHub and it messed up the commit history. |
Changed the
Session.Connectto useThreadAbstraction.ExecuteThreadLongRunningto start theMessageListener.The commit 5d173c8 also includes cleanup of
ThreadAbstraction, which I did because I wasn't sure anymore which target was used as a dependency. I feel this cleanup is beneficial in the long run, but if you feel this is too much for this PR let me know and I'll roll it back.Fixes #824