-
Notifications
You must be signed in to change notification settings - Fork 53
IO updates, new StacApiIO class #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eate new StacApiIO class)
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 85.23% 82.66% -2.57%
==========================================
Files 13 8 -5
Lines 630 427 -203
==========================================
- Hits 537 353 -184
+ Misses 93 74 -19
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a chance to look through the item_search.py
changes in detail, but the rest looks good. I really like this new way of handling the conformance classes and the new mixin!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this review came in so piecemeal, I didn't have a chunk of time to actually devote to this until just now.
It looks like scripts/build-docs
fails because there are still some references to classes that were removed from client.rst
. It also looks like there's something weird going on with the published documentation. I get a "SORRY This page does not exist yet." message from the site. There seems to generally be some places where the docs haven't caught up to the code yet. Not sure if you want to fix that in this PR, but it might be worth tracking so that things don't get too out of sync.
Co-authored-by: Jon Duckworth <[email protected]>
Co-authored-by: Jon Duckworth <[email protected]>
Co-authored-by: Jon Duckworth <[email protected]>
Co-authored-by: Jon Duckworth <[email protected]>
Related Issue(s): #
#61 #62
Description:
PR Checklist: