Skip to content

Drop pyright type checking #381

@duckontheweb

Description

@duckontheweb

Starting with c073712, we started using pyright instead of mypy for type checking in our tests/CI. There were some good reasons for this (outlined in the comments of that commit), but since then we have re-adopted mypy (via #337).

This issue exists to discuss whether we should drop the use of pyright for type checking in our tests and CI.

I'm personally +1 for dropping pyright for the following reasons:

  • Using pyright adds a Node.js/npm dependency to a project that is otherwise purely Python
  • mypy seems to be the stricter of the two type checkers, so it's not obvious to me that pyright is adding anything

Metadata

Metadata

Assignees

Labels

discussionAn issue to capture a discussion

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions