Skip to content

Test both with and without orjson #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
l0b0 opened this issue Jun 24, 2021 · 2 comments · Fixed by #914
Closed

Test both with and without orjson #475

l0b0 opened this issue Jun 24, 2021 · 2 comments · Fixed by #914

Comments

@l0b0
Copy link
Contributor

l0b0 commented Jun 24, 2021

Currently the test suite installs the optional dependency orjson. To make sure pystac also works without orjson we should run the test suite both with and without it. We can use coverage --append to merge the coverage information from both runs.

@gadomski
Copy link
Member

gadomski commented Nov 8, 2022

We added CI tests w/o orjson in #348. Coverage is not merged -- @l0b0 how critical would you consider merging that coverage data? Can we close this issue?

@l0b0
Copy link
Contributor Author

l0b0 commented Nov 9, 2022

Merging the coverage (it's easy) would give a more accurate coverage metric, and would be necessary to eventually reach 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants