Skip to content

Run coverage w/o orjson #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Nov 9, 2022

Related Issue(s):

Description:

Run coverage with and without orjson, accumulating results with --append. cc @l0b0

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski force-pushed the issues/475-coverage-without-orjson branch from ebe5098 to 4ac5b42 Compare November 9, 2022 17:22
@gadomski gadomski added the tests Issues or pull requests that relate to the test suite label Nov 9, 2022
@gadomski gadomski self-assigned this Dec 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Base: 94.37% // Head: 94.42% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (0baa3d7) compared to base (d28bd43).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
+ Coverage   94.37%   94.42%   +0.04%     
==========================================
  Files          83       83              
  Lines       12016    12016              
  Branches     1136     1136              
==========================================
+ Hits        11340    11346       +6     
+ Misses        496      492       -4     
+ Partials      180      178       -2     
Impacted Files Coverage Δ
pystac/stac_io.py 93.04% <0.00%> (+5.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski requested a review from pjhartzell January 6, 2023 20:37
Copy link
Collaborator

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gadomski gadomski merged commit a66559a into main Jan 6, 2023
@gadomski gadomski deleted the issues/475-coverage-without-orjson branch January 6, 2023 21:55
@gadomski gadomski added this to the 1.7 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or pull requests that relate to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test both with and without orjson
4 participants