Skip to content

Add MGRS Extension from code in stactools-package for sentinel2 #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Apr 7, 2023

Related Issue(s):

Description:

Code from: https://github.com/stactools-packages/sentinel2/blob/main/src/stactools/sentinel2/mgrs.py
Example from: https://github.com/stac-extensions/mgrs/blob/main/examples/item.json

Added pytest-style tests, docs

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jsignell jsignell linked an issue Apr 7, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Patch coverage: 96.10% and project coverage change: +0.07 🎉

Comparison is base (1fa72d0) 90.23% compared to head (71bf305) 90.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
+ Coverage   90.23%   90.30%   +0.07%     
==========================================
  Files          47       48       +1     
  Lines        6236     6313      +77     
  Branches      936      943       +7     
==========================================
+ Hits         5627     5701      +74     
- Misses        428      430       +2     
- Partials      181      182       +1     
Impacted Files Coverage Δ
pystac/extensions/mgrs.py 96.05% <96.05%> (ø)
pystac/__init__.py 94.11% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski added this to the 1.8 milestone Apr 10, 2023
@gadomski gadomski self-requested a review April 10, 2023 11:48
@jsignell jsignell requested a review from gadomski April 11, 2023 15:01
@jsignell jsignell mentioned this pull request Apr 11, 2023
5 tasks
From code in stactools-package for sentinel2

Co-authored-by: Pete Gadomski <[email protected]>
@gadomski gadomski enabled auto-merge April 12, 2023 22:12
@gadomski gadomski added this pull request to the merge queue Apr 12, 2023
Merged via the queue into stac-utils:main with commit 1cd4b42 Apr 12, 2023
@jsignell jsignell deleted the mgrs branch April 13, 2023 13:40
@philvarner
Copy link
Collaborator

Thanks for doing this @jsignell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create MGRS Extension from code in stactools-package for sentinel2
4 participants