Allow more configuration with Catalog.validate_all
#1141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsignell
commented
Jun 2, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
+ Coverage 91.17% 91.18% +0.01%
==========================================
Files 49 49
Lines 6626 6634 +8
Branches 978 980 +2
==========================================
+ Hits 6041 6049 +8
Misses 410 410
Partials 175 175
☔ View full report in Codecov by Sentry. |
ircwaves
approved these changes
Jun 5, 2023
ircwaves
approved these changes
Jun 7, 2023
|
Between the attempt to skip CI and the force push I broke this PR 🤦 Opening a new one now |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
I think this covers the scenario described in the original issue of limiting the amount of objects that are iterated over. It made more sense to be to track that as a single number (items + catalogs + collections) and then to separately give a knob for changing whether or no we recurse into the children.
That being said there are lots of ways to tackle this. Anther approach could use a timeout rather than tracking number of objects at all.
PR Checklist:
pre-commithooks pass locallyscripts/test)