Skip to content

Update file extension and add Link.ext #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 17, 2023
Merged

Update file extension and add Link.ext #1265

merged 8 commits into from
Oct 17, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Oct 13, 2023 •
edited
Loading

Related Issue(s):

Description:

The update added a new field and let the ext apply to links and catalogs.
This is the first extension in pystac that can operate on a Link so I added the Link.ext syntax as well.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pystac/extensions/base.py 88.88% <100.00%> (ø)
pystac/extensions/ext.py 96.80% <100.00%> (+0.16%) ⬆️
pystac/link.py 91.74% <100.00%> (+0.16%) ⬆️
pystac/extensions/file.py 91.66% <94.11%> (-0.25%) ⬇️

📢 Thoughts on this report? Let us know!.

@gadomski gadomski linked an issue Oct 16, 2023 that may be closed by this pull request
Update file extension to v2.1.0 #1247
Closed
@jsignell jsignell requested a review from gadomski October 17, 2023 15:49
@gadomski gadomski added this pull request to the merge queue Oct 17, 2023
Merged via the queue into stac-utils:main with commit d7a6712 Oct 17, 2023
@jsignell jsignell deleted the file-ext branch October 17, 2023 17:57
@jsignell jsignell mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update file extension to v2.1.0
2 participants
@jsignell @gadomski