993 progress: two more files converted to pytest, one remaining#1535
Merged
gadomski merged 23 commits intostac-utils:mainfrom Mar 5, 2025
Merged
993 progress: two more files converted to pytest, one remaining#1535gadomski merged 23 commits intostac-utils:mainfrom
gadomski merged 23 commits intostac-utils:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1535 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 54 54
Lines 7571 7571
Branches 922 922
=======================================
Hits 6927 6927
Misses 457 457
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gadomski
approved these changes
Mar 5, 2025
|
|
||
| @pytest.fixture | ||
| def multi_extent_collection() -> Collection: | ||
| # TODO this code is repeated many times; refactor to use this fixture |
kmodali
pushed a commit
to kmodali/pystac
that referenced
this pull request
Oct 16, 2025
…-utils#1535) * 993 pull out constants to module scope * 993 convert assertions in test_storage.py * 993 convert a test * 993 convert a test using conftest fixture * 993 convert test_validate_storage to pytest * 993 easy test conversion * 993 convert remainder of tests in ItemStorageExtensionTest * 993 refactor test classes as a prelude to declassing * 993 convert a test from StorageExtensionSummariesTest * 993 rename for clarity post-declass * 993 declass StorageExtensionSummariesTest tests * 993 finish declassing * 993 declass AssetStorageExtensionTest * 993 finish declassing * 993 better names for asset tests * 993 start on test_timestamps.py * 993 replace assertions * 993 relocate cassettes prior to declassing * 993 set up for test conversion * 993 yet another nonfunctional declassing * 993 convert tests to pytest * 993 convert TimestampsSummariesTest * 993 ruff's opinions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #993
Description: Converted
tests/extensions/test_storage.pyandtests/extensions/test_timestamps.py, onlytests/extensions/test_view.pyremains.PR Checklist:
pre-commit run --all-files)pytest)Documentation has been updated to reflect changes, if applicableor improvesoverall codebase code coverage.Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.