Skip to content

update storage extension to v2.0.0 #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tylanderson
Copy link
Contributor

@tylanderson tylanderson commented Jun 2, 2025

Description:

Updates storage extension to v2.0.0. Due to the major changes in v2, I have not attempted to make migrations from v1 to v2

StorageScheme platform property allows templated uri's, so arbitrary additional properties are allowed to be set on StorageScheme objects

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 98.78788% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.57%. Comparing base (7621455) to head (65f3f83).

Files with missing lines Patch % Lines
pystac/extensions/storage.py 98.67% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
+ Coverage   92.43%   92.57%   +0.13%     
==========================================
  Files          55       55              
  Lines        8371     8456      +85     
  Branches      964      972       +8     
==========================================
+ Hits         7738     7828      +90     
+ Misses        449      445       -4     
+ Partials      184      183       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tylanderson tylanderson marked this pull request as ready for review June 24, 2025 21:26
@gadomski gadomski self-requested a review June 25, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant