Skip to content

FIX: update tests for github runner drive changes #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tylanderson
Copy link
Contributor

@tylanderson tylanderson commented Jun 18, 2025

Description:

Hit this issue during test run for storage extension test job run, looks like D:\ drive is no longer accessible on the windows runners

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@tylanderson tylanderson marked this pull request as ready for review June 18, 2025 21:41
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (7621455) to head (36a3da5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1563   +/-   ##
=======================================
  Coverage   92.43%   92.43%           
=======================================
  Files          55       55           
  Lines        8371     8371           
  Branches      964      964           
=======================================
  Hits         7738     7738           
  Misses        449      449           
  Partials      184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gadomski
Copy link
Member

Thanks!

@gadomski gadomski added this pull request to the merge queue Jun 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2025
@gadomski
Copy link
Member

😕 looks like this failed in the merge queue: https://github.com/stac-utils/pystac/actions/runs/15852035567/job/44687723893

Not sure why the branch is different than the merge queue ...

@tylanderson
Copy link
Contributor Author

😕 looks like this failed in the merge queue: https://github.com/stac-utils/pystac/actions/runs/15852035567/job/44687723893

Not sure why the branch is different than the merge queue ...

no problem, I'll take a look at why and see if something has changed again

@tylanderson
Copy link
Contributor Author

It looks like this was an unintended change to this runner: actions/runner-images#12386

However it will in the future impact windows-2025, which is GA, but not tagged as window-latest yet. I'm going to propose leaving this in draft until that is announced to be the new -latest window runner

@tylanderson tylanderson marked this pull request as draft June 24, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants