Skip to content

fix: mypy typing#1569

Merged
gadomski merged 2 commits intomainfrom
mypy-update
Jul 29, 2025
Merged

fix: mypy typing#1569
gadomski merged 2 commits intomainfrom
mypy-update

Conversation

@gadomski
Copy link
Member

Description:

Update mypy dependency, and fix some (mostly trivial) typing nits that it threw up.

Yet another reminder that our extension setup is -- messy 😢

@gadomski gadomski requested a review from jsignell July 29, 2025 11:46
@gadomski gadomski self-assigned this Jul 29, 2025
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.38%. Comparing base (8bc0151) to head (55c7075).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pystac/extensions/datacube.py 50.00% 2 Missing ⚠️
pystac/extensions/table.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1569   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          55       55           
  Lines        8374     8374           
  Branches      965      965           
=======================================
  Hits         7736     7736           
  Misses        453      453           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gadomski gadomski added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 65562c1 Jul 29, 2025
19 checks passed
@gadomski gadomski deleted the mypy-update branch July 29, 2025 15:57
kmodali pushed a commit to kmodali/pystac that referenced this pull request Oct 16, 2025
* fix: mypy typing

* chore: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants