Support older versions of urllib3#1580
Merged
jsignell merged 1 commit intostac-utils:mainfrom Sep 18, 2025
Merged
Conversation
jsignell
commented
Sep 18, 2025
| "types-python-dateutil>=2.9.0.20241003", | ||
| "types-urllib3>=1.26.25.14", | ||
| "urllib3>=2.3.0", | ||
| "urllib3>=1.26.19", |
Member
Author
There was a problem hiding this comment.
To test this change I set this to "urllib3==1.26.19", locally and ran tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 55 55
Lines 8374 8375 +1
Branches 965 965
=======================================
+ Hits 7736 7737 +1
Misses 453 453
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gadomski
approved these changes
Sep 18, 2025
Merged
kmodali
pushed a commit
to kmodali/pystac
that referenced
this pull request
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
This is a really simple tweak that supports v1 of urllib3.
PR Checklist:
pre-commit run --all-files)pytest)