Skip to content

Support older versions of urllib3#1580

Merged
jsignell merged 1 commit intostac-utils:mainfrom
jsignell:older-urllib3-support
Sep 18, 2025
Merged

Support older versions of urllib3#1580
jsignell merged 1 commit intostac-utils:mainfrom
jsignell:older-urllib3-support

Conversation

@jsignell
Copy link
Member

@jsignell jsignell commented Sep 18, 2025

Related Issue(s):

Description:

This is a really simple tweak that supports v1 of urllib3.

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

"types-python-dateutil>=2.9.0.20241003",
"types-urllib3>=1.26.25.14",
"urllib3>=2.3.0",
"urllib3>=1.26.19",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test this change I set this to "urllib3==1.26.19", locally and ran tests.

@jsignell jsignell requested a review from gadomski September 18, 2025 14:17
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (44d06af) to head (1df2630).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1580   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          55       55           
  Lines        8374     8375    +1     
  Branches      965      965           
=======================================
+ Hits         7736     7737    +1     
  Misses        453      453           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsignell jsignell added this pull request to the merge queue Sep 18, 2025
Merged via the queue into stac-utils:main with commit 0e13b6a Sep 18, 2025
19 checks passed
@jsignell jsignell deleted the older-urllib3-support branch September 18, 2025 14:49
@jsignell jsignell mentioned this pull request Sep 18, 2025
kmodali pushed a commit to kmodali/pystac that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support older versions of urllib3

2 participants