Skip to content

Conversation

@jsignell
Copy link
Member

@jsignell jsignell commented Nov 28, 2025

Related Issue(s):

Description:

As @fmigneault points out. This field should not be required on the vertical dimension

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.29%. Comparing base (aec5ec0) to head (070c2e8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pystac/extensions/datacube.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
- Coverage   92.30%   92.29%   -0.02%     
==========================================
  Files          55       55              
  Lines        8387     8395       +8     
  Branches      970      971       +1     
==========================================
+ Hits         7742     7748       +6     
- Misses        457      458       +1     
- Partials      188      189       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsignell jsignell enabled auto-merge December 1, 2025 14:14
@jsignell jsignell added this pull request to the merge queue Dec 1, 2025
Merged via the queue into stac-utils:main with commit 608972a Dec 1, 2025
19 checks passed
@jsignell jsignell deleted the datacube-extent branch December 1, 2025 14:17
@fmigneault
Copy link
Contributor

Thanks @jsignell @gadomski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Datacube VerticalSpatialDimension enforces optional extent

3 participants