Skip to content

Updates to CI and README #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2021

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jun 17, 2021

Description:

  • Removes Gitter badge since that channel is mostly unused
  • Adds orjson extra install instructions
  • Minor clarifications around versions
  • Only run release build for this repo (I was seeing failed builds in my fork when I updated tags)
  • Move coverage reporting into separate job
    Since we added the minimum coverage requirement, the test job fails before uploading coverage to Codecov.io. When I was working on removing support for pre-0.8 STAC versions I found myself wishing I could use that UI to figure out where the coverage had dropped. This change means the CI workflow will still fail overall, but we will still get a coverage report we can look at if we drop below the minimum threshhold.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from lossyrob June 17, 2021 16:05
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #452 (6174b4c) into main (a729cd2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files          40       40           
  Lines        5204     5204           
=======================================
  Hits         4752     4752           
  Misses        452      452           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a729cd2...6174b4c. Read the comment docs.

Copy link
Member

@lossyrob lossyrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with one suggestion

@duckontheweb duckontheweb merged commit 012833a into stac-utils:main Jun 17, 2021
@duckontheweb duckontheweb deleted the change/ci-and-readme branch June 17, 2021 23:58
@duckontheweb duckontheweb mentioned this pull request Jun 26, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants