Improve coverage checks

.coveragerc

@@ -1,5 +1,11 @@
 [report]
-fail_under = 91
+fail_under = 93
+exclude_lines =
+    if TYPE_CHECKING:
+
 
 [run]
-source = pystac
+branch = true
+source =
+    pystac
+    tests

pystac/extensions/sar.py

@@ -318,7 +318,7 @@ def ext(cls, obj: T, add_if_missing: bool = False) -> "SarExtension[T]":
             return cast(SarExtension[T], AssetSarExtension(obj))
         else:
             raise pystac.ExtensionTypeError(
-                f"SAR extension does not apply to type {type(obj)}"
+                f"SAR extension does not apply to type '{type(obj).__name__}'"
             )
 
 

pystac/extensions/view.py

@@ -167,7 +167,7 @@ def ext(cls, obj: T, add_if_missing: bool = False) -> "ViewExtension[T]":
             return cast(ViewExtension[T], AssetViewExtension(obj))
         else:
             raise pystac.ExtensionTypeError(
-                f"View extension does not apply to type {type(obj)}"
+                f"View extension does not apply to type '{type(obj).__name__}'"
             )
 
     @staticmethod

scripts/test

@@ -11,5 +11,5 @@ echo " -- RUNNING UNIT TESTS --"
 echo
 
 # Test suite with coverage enabled
-coverage run --source=pystac/ -m unittest discover tests/
+coverage run -m unittest discover tests
 coverage xml

tests/extensions/test_sar.py

@@ -1,10 +1,14 @@
 """Tests for pystac.extensions.sar."""
 
 import datetime
+from random import choice
 from typing import List
 import unittest
 
+from string import ascii_letters
+
 import pystac
+from pystac import ExtensionTypeError
 from pystac.extensions import sar
 from pystac.extensions.sar import SarExtension
 from tests.utils import TestCases
@@ -180,6 +184,26 @@ def test_asset_ext_add_to(self) -> None:
 
         self.assertIn(SarExtension.get_schema_uri(), item.stac_extensions)
 
+    def test_should_return_none_when_observation_direction_is_not_set(self) -> None:
+        extension = SarExtension.ext(self.item)
+        extension.apply(
+            choice(ascii_letters),
+            choice(list(sar.FrequencyBand)),
+            [],
+            choice(ascii_letters),
+        )
+        self.assertIsNone(extension.observation_direction)
+
+    def test_should_raise_exception_when_passing_invalid_extension_object(
+        self,
+    ) -> None:
+        self.assertRaisesRegex(
+            ExtensionTypeError,
+            r"^SAR extension does not apply to type 'object'$",
+            SarExtension.ext,
+            object(),
+        )
+
 
 if __name__ == "__main__":
     unittest.main()

tests/extensions/test_view.py

@@ -1,4 +1,6 @@
 import json
+
+from pystac import ExtensionTypeError
 from pystac.collection import Collection
 import unittest
 
@@ -257,8 +259,18 @@ def test_asset_ext_add_to(self) -> None:
 
         self.assertIn(ViewExtension.get_schema_uri(), item.stac_extensions)
 
+    def test_should_raise_exception_when_passing_invalid_extension_object(
+        self,
+    ) -> None:
+        self.assertRaisesRegex(
+            ExtensionTypeError,
+            r"^View extension does not apply to type 'object'$",
+            ViewExtension.ext,
+            object(),
+        )
+
 
-class ViewSummariestest(unittest.TestCase):
+class ViewSummariesTest(unittest.TestCase):
     def setUp(self) -> None:
         self.maxDiff = None
         example_uri = TestCases.get_path(

tests/test_catalog.py

@@ -939,7 +939,7 @@ def test_collections_cache_correctly(self) -> None:
 
     def test_reading_iterating_and_writing_works_as_expected(self) -> None:
         """Test case to cover issue #88"""
-        stac_uri = "tests/data-files/catalogs/test-case-6/catalog.json"
+        stac_uri = TestCases.get_path("data-files/catalogs/test-case-6/catalog.json")
         cat = Catalog.from_file(stac_uri)
 
         # Iterate over the items. This was causing failure in

tests/test_item_collection.py

@@ -2,6 +2,8 @@
 import json
 from pystac.item_collection import ItemCollection
 import unittest
+from os.path import relpath
+
 import pystac
 
 from tests.utils import TestCases
@@ -101,7 +103,11 @@ def test_raise_error_for_invalid_object(self) -> None:
 
     def test_from_relative_path(self) -> None:
         _ = pystac.ItemCollection.from_file(
-            "./tests/data-files/item-collection/sample-item-collection.json"
+            relpath(
+                TestCases.get_path(
+                    "data-files/item-collection/sample-item-collection.json"
+                )
+            )
         )
 
     def test_from_list_of_dicts(self) -> None:

tests/test_utils.py

@@ -8,6 +8,7 @@
 from pystac import utils
 
 from pystac.utils import make_relative_href, make_absolute_href, is_absolute_href
+from tests.utils import TestCases
 
 
 class UtilsTest(unittest.TestCase):
@@ -273,7 +274,9 @@ def test_datetime_to_str(self) -> None:
 
     def test_geojson_bbox(self) -> None:
         # Use sample Geojson from https://en.wikipedia.org/wiki/GeoJSON
-        with open("tests/data-files/geojson/sample.geojson") as sample_geojson:
+        with open(
+            TestCases.get_path("data-files/geojson/sample.geojson")
+        ) as sample_geojson:
             all_features = json.load(sample_geojson)
             geom_dicts = [f["geometry"] for f in all_features["features"]]
             for geom in geom_dicts: