Run test script with/without coverage #486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #
Description:
Adds ability to run
scripts/test
with or without coverage (default outside of CI is still to run with coverage).Also moves generation of
coverage.xml
out ofscripts/test
. The XML file is mostly used when uploading coverage to Codecov.io. Generating this file would cause alltest
jobs in the matrix to fail if the coverage dropped, which is misleading. Instead, this PR updates thecoverage
CI job to first upload the coverage report to Codecov.io so we can use it for debugging, then generates the report again using the configuredfail-under
value, which will causecoverage
job to fail if coverage drops. This should make the source of the workflow failure a bit more obvious to developers.PR Checklist:
pre-commit run --all-files
)scripts/test
)