Skip to content

Conversation

@l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jun 29, 2021

Related Issue(s): #331

Description:

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

Codecov Report

Merging #491 (0bac98a) into main (f9573f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #491   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files          40       40           
  Lines        5245     5245           
=======================================
  Hits         4808     4808           
  Misses        437      437           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9573f8...0bac98a. Read the comment docs.

@l0b0
Copy link
Contributor Author

l0b0 commented Jun 29, 2021

This needs to be re-run because of a flaky test.

@duckontheweb
Copy link
Contributor

This needs to be re-run because of a flaky test.

Yeah, I've been running into this a lot more lately for some reason. Thanks for opening #494 for this!

Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to be rebased to reconcile with #492, but other than that it looks good to me.

@l0b0 l0b0 force-pushed the bump-coverage-minimum branch from 0bac98a to fe34214 Compare June 29, 2021 23:25
@l0b0 l0b0 changed the title tests: Bump coverage minimum to 92% tests: Bump coverage minimum to 95% Jun 29, 2021
@duckontheweb duckontheweb merged commit 301f663 into stac-utils:main Jun 30, 2021
@l0b0 l0b0 deleted the bump-coverage-minimum branch June 30, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants