tests: Verify branch coverage #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 95.65% 93.96% -1.70%
==========================================
Files 71 71
Lines 9991 9991
Branches 0 1061 +1061
==========================================
- Hits 9557 9388 -169
Misses 434 434
- Partials 0 169 +169
Continue to review full report at Codecov.
|
l0b0
force-pushed
the
verify-branch-coverage
branch
2 times, most recently
from
3d6512b to
69f6992
Compare
Stricter than statement coverage, so I had to take the coverage minimum down two percentage points. The coverage library does not yet have support for conditional coverage <nedbat/coveragepy#660>, which is even stricter.
l0b0
force-pushed
the
verify-branch-coverage
branch
from
69f6992 to
fff4751
Compare
duckontheweb
approved these changes
Jul 1, 2021
|
Thanks for this, it's definitely catching some cases that were being missed in statement coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stricter than statement coverage, so I had to take the coverage minimum
down one percentage point.
The coverage library does not yet have support for conditional coverage
nedbat/coveragepy#660, which is even
stricter.
Hover over yellow lines in the output of
coverage htmlfor a good idea of the difference between this and line coverage.Related Issue(s): #331
PR Checklist:
pre-commit run --all-files)scripts/test)