fix root-path from uvicorn #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
requested review from
hrodmn and
gadomski
and removed request for
hrodmn
gadomski
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
LGTM, looks like the docs check is broken. I dug into it a little bit, can't pin down exactly what's going on, best guess is that there's some new relative links in the pydantic docs that are getting pulled in by pdoc. Best mitigation would be to switch over to mkdocstrings-python, but that's a non-zero lift, so I'd be ok w/ just dropping the --strict from the docs test build for now and adding a tracking issue to fix the docs, so as to not block this PR?
|
I'll fix the doc in another PR 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #220
cc @sunu