Skip to content

Enable mypy #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gadomski opened this issue Jul 2, 2021 · 2 comments · Fixed by #182
Closed

Enable mypy #155

gadomski opened this issue Jul 2, 2021 · 2 comments · Fixed by #182
Assignees
@cuttlefish
Labels
enhancement New feature or request

Comments

@gadomski
Copy link
Member

gadomski commented Jul 2, 2021

Static typing is good we and we should use it if we can.
@gadomski gadomski added the enhancement New feature or request label Jul 12, 2021
@cuttlefish
Copy link
Collaborator

I don't want to derail, but I'm curious if anyone has tried any of the alternatives? Pyright, Pyre, Pytype, etc.
mypy is the only one I've used.

@gadomski
Copy link
Member Author

PySTAC used pyright for a while: stac-utils/pystac#381. Personally I agree with @duckontheweb's points:

  • Using pyright adds a Node.js/npm dependency to a project that is otherwise purely Python
  • mypy seems to be the stricter of the two type checkers, so it's not obvious to me that pyright is adding anything

Plus it's nice to align with our upstream. But good to consider for sure!

This was referenced Jul 26, 2021
Closed
Merged
Merged
@cuttlefish cuttlefish self-assigned this Jul 27, 2021
@cuttlefish cuttlefish mentioned this issue Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuttlefish cuttlefish

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mypy stac-utils/stactools
2 participants
@gadomski @cuttlefish