Skip to content

feat(run-pre-commit): Enable caching, support pre-commit pinning #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 17, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Apr 17, 2025

Part of stackabletech/operator-templating#503

This PR enables caching for:

  • pip: Reduces time from 49s to 12s (in this repo), which is a 75% decrease in time
  • rust: Hard to measure individually, but it roughly went from 10s to 3s (in this repo), which is a 70% decrease in time

Very simple testing in stackabletech/operator-rs#1014 showed a reduction from 1m2s to 23s, which is roughly a 62% speedup (for run 1+n).


It also enables pinning pre-commit to a specific version. Before, the action always installed the latest available version.

@Techassi Techassi self-assigned this Apr 17, 2025
@Techassi Techassi changed the title feat(run-pre-commit): Enable caching feat(run-pre-commit): Enable caching, support pre-commit pinning Apr 17, 2025
@Techassi Techassi force-pushed the feat/run-pre-commit-caching branch from 7822df6 to a9d431e Compare April 17, 2025 12:59
@Techassi Techassi force-pushed the feat/run-pre-commit-caching branch from a9d431e to fe22813 Compare April 17, 2025 13:03
@Techassi Techassi marked this pull request as ready for review April 17, 2025 13:06
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Apr 17, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. LGTM

@Techassi Techassi merged commit 16d2175 into main Apr 17, 2025
2 checks passed
@Techassi Techassi deleted the feat/run-pre-commit-caching branch April 17, 2025 21:39
@Techassi Techassi moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Apr 22, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants