Skip to content

feat: add spark connect client to image build flows #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

razvan
Copy link
Member

@razvan razvan commented Apr 4, 2025

Description

Part of stackabletech/spark-k8s-operator#284

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan self-assigned this Apr 4, 2025
@razvan razvan requested a review from a team April 4, 2025 08:51
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Apr 4, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Apr 4, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks fine, but maybe review the workflow path's list.

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 4, 2025
@razvan
Copy link
Member Author

razvan commented Apr 4, 2025

Mostly looks fine, but maybe review the workflow path's list.

done. would you approve again?

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Apr 4, 2025
@razvan
Copy link
Member Author

razvan commented Apr 4, 2025

thanks!

Merged via the queue into main with commit b2cec4c Apr 4, 2025
3 checks passed
@razvan razvan deleted the feat/spark-connect-flow branch April 4, 2025 09:16
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Apr 14, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants