chore: stop building kcat image #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dervoeti
force-pushed
the
chore/stop-building-kcat
branch
from
ed741e4 to
c34a98d
Compare
dervoeti
added
release/25.7.0
release-note/action-required
dervoeti
force-pushed
the
chore/stop-building-kcat
branch
4 times, most recently
from
d330452 to
c06b5e6
Compare
razvan
reviewed
May 21, 2025
dervoeti
force-pushed
the
chore/stop-building-kcat
branch
from
c06b5e6 to
2216303
Compare
Good catch, adjusted it! |
dervoeti
added a commit
that referenced
this pull request
May 23, 2025
* chore: stop building kcat image * fix: adjust kafka / kafka-testing-tools watched paths
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
lfrancke
moved this from Development: Done
to Acceptance: In Progress
in Stackable Engineering
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 27, 2025
* feat: include source code of components / migrate some components to patchable * chore(deps): update docker/dockerfile docker tag to v1.15.1 (#1120) | datasource | package | from | to | | ---------- | ----------------- | ------ | ------ | | docker | docker/dockerfile | 1.10.0 | 1.15.1 | * chore: Update pre-commit dependencies (#1123) * chore(kafka): update images for release 25.7.0 (#1117) * remove 3.7.1 and 3.8.0 * add 4.0.0 * update changelog * bump to java 23 for kafka 4.0.0 * fix kcat image name * chore: stop building kcat image (#1124) * chore: stop building kcat image * fix: adjust kafka / kafka-testing-tools watched paths * chore: changelog / hadolint fix * fix: missing patchable config for protobuf * Update hadoop/Dockerfile Co-authored-by: Malte Sander <[email protected]> * chore: move chmod to builder step * fix: spark build --------- Co-authored-by: Stacky McStackface <[email protected]> Co-authored-by: Lars Francke <[email protected]> Co-authored-by: Razvan-Daniel Mihai <[email protected]> Co-authored-by: Malte Sander <[email protected]>
|
Can you please add release notes? |
Release noteBREAKING: The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have an image
sdp/kcatand alsosdp/kafka-testing-tools, which seems to contain kcat (and nothing else really).sdp/kafka-testing-toolsis used in a kuttl test for kafka-operator.As far as I see, the published
sdp/kcatimage is not used anywhere. The image neither has our usual labels nor an entrypoint.I don't see a reason why we publish the kcat image or why anyone would use it (
kafka-testing-toolsseems to be the proper image that contains kcat since it has labels and an entrypoint), it looks like it's just an intermediate image that was published for some reason.The plan is: Keep all the current
sdp/kcatimages around, just to be safe, but stop building new ones for upcoming releases, mainly to avoid confusion because we currently have two images that essentially contain the same thing (kcatandkafka-testing-tools). So this PR just removes the Github Action that publishessdp/kcat.This should be mentioned in the release notes.
Also: Fixed a bug in
.scripts/update_readme_badges.shthat broke the pre-commit checks in this case (number of columns at the end was hardcoded).Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.