chore(deps): update dependency pagefind to v1.1.1 [security] #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| datasource | package | from | to | | ---------- | -------- | ----- | ----- | | npm | pagefind | 1.1.0 | 1.1.1 |
stackable-bot
force-pushed
the
renovate/npm-pagefind-vulnerability
branch
from
7d26c2e to
5bc670e
Compare
|
@lfrancke, the build keeps failing on this branch. |
|
I'll close this in favor of #656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.1.0->1.1.1GitHub Vulnerability Alerts
CVE-2024-45389
Pagefind initializes its dynamic JavaScript and WebAssembly files relative to the location of the first script you load. This information is gathered by looking up the value of
document.currentScript.src.It is possible to "clobber" this lookup with otherwise benign HTML on the page, for example:
This will cause
document.currentScript.srcto resolve as an external domain, which will then be used by Pagefind to load dependencies.This exploit would only work in the case that an attacker could inject HTML to your live, hosted, website. In these cases, this would act as a way to escalate the privilege available to an attacker. This assumes they have the ability to add some elements to the page (for example,
imgtags with anameattribute), but not others, as adding ascriptto the page would itself be the XSS vector.Pagefind has tightened this resolution by ensuring the source is loaded from a valid script element. There are no reports of this being exploited in the wild via Pagefind.
Original Report
If an attacker can inject benign html, such as:
<img name="currentScript" src="blob:https://xxx.xxx.xxx/ui.js"></img>they can clobber
document.currentScript.srcleading to XSS in your library.Here is the same attack on webpack that was accepted: GHSA-4vvj-4cpr-p986
Release Notes
CloudCannon/pagefind (pagefind)
v1.1.1Compare Source
Fixes & Tweaks
UI Translations
Secutiry
Configuration
📅 Schedule: Branch creation - "" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot.