-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add OIDC support #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…' into feat/oidc-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments. The PR could use some more docs / (method) comments / module headers (and tracing as always). E.g. operator-binary/src/authentication/oidc_.rs
could use a module header with e.g. a link for the required properties (similar for ldap although not in scope here).
tests/templates/kuttl/oidc/35-install-authentication-class.yaml.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Updated the feature tracker ✔️ |
Description
ClientAuthenticationDetails
fromoperator-rs
Integration tests (nightly) were successful: https://ci.stackable.tech/view/06%20Replicated%20(Demo)/job/druid-operator-it-replicated/17/console
Definition of Done Checklist