Skip to content

feat: Add OIDC support #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 58 commits into from
Jul 17, 2024
Merged

feat: Add OIDC support #573

merged 58 commits into from
Jul 17, 2024

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Jun 14, 2024

Description

  • Add support for OIDC with/without TLS
  • Refactor authentication changing CRD to ClientAuthenticationDetails from operator-rs
  • Add debug profile for VS Code
  • Update documentation

Integration tests (nightly) were successful: https://ci.stackable.tech/view/06%20Replicated%20(Demo)/job/druid-operator-it-replicated/17/console

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [x] Code contains useful comments
- [x] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [x] Feature Tracker has been updated
- [x] Proper release label has been added
- [x] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@labrenbe labrenbe changed the title OIDC support feat: add OIDC support Jun 14, 2024
@labrenbe labrenbe removed the request for review from fhennig July 16, 2024 07:20
@labrenbe labrenbe self-assigned this Jul 16, 2024
@maltesander maltesander self-requested a review July 16, 2024 07:39
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments. The PR could use some more docs / (method) comments / module headers (and tracing as always). E.g. operator-binary/src/authentication/oidc_.rs could use a module header with e.g. a link for the required properties (similar for ldap although not in scope here).

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@labrenbe labrenbe enabled auto-merge July 17, 2024 09:47
@labrenbe labrenbe added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit b80284a Jul 17, 2024
32 checks passed
@labrenbe labrenbe deleted the feat/oidc-support branch July 17, 2024 09:58
@sbernauer
Copy link
Member

sbernauer commented Aug 5, 2024

Updated the feature tracker ✔️
Also release the 24.07 release in feature tracker and added this feature it to the Roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OpenID Connect support
4 participants