Skip to content

fix: Invalid CRD schema for StackableAffinity contents #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 9, 2024

Description

Fixup of #821

Before

The CustomResourceDefinition "druidclusters.druid.stackable.tech" is invalid: 
* spec.validation.openAPIV3Schema.properties[spec].properties[coordinators].properties[config].properties[affinity].default.podAffinity: Invalid value: "null": podAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[coordinators].properties[config].properties[affinity].default.podAntiAffinity: Invalid value: "null": podAntiAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[coordinators].properties[config].properties[affinity].default.nodeAffinity: Invalid value: "null": nodeAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[historicals].properties[config].properties[affinity].default.nodeAffinity: Invalid value: "null": nodeAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[historicals].properties[config].properties[affinity].default.podAffinity: Invalid value: "null": podAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[historicals].properties[config].properties[affinity].default.podAntiAffinity: Invalid value: "null": podAntiAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[middleManagers].properties[config].properties[affinity].default.podAntiAffinity: Invalid value: "null": podAntiAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[middleManagers].properties[config].properties[affinity].default.nodeAffinity: Invalid value: "null": nodeAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[middleManagers].properties[config].properties[affinity].default.podAffinity: Invalid value: "null": podAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[routers].properties[config].properties[affinity].default.podAffinity: Invalid value: "null": podAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[routers].properties[config].properties[affinity].default.podAntiAffinity: Invalid value: "null": podAntiAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[routers].properties[config].properties[affinity].default.nodeAffinity: Invalid value: "null": nodeAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[brokers].properties[config].properties[affinity].default.nodeAffinity: Invalid value: "null": nodeAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[brokers].properties[config].properties[affinity].default.podAffinity: Invalid value: "null": podAffinity in body must be of type object: "null"
* spec.validation.openAPIV3Schema.properties[spec].properties[brokers].properties[config].properties[affinity].default.podAntiAffinity: Invalid value: "null": podAntiAffinity in body must be of type object: "null"

After

customresourcedefinition.apiextensions.k8s.io/druidclusters.druid.stackable.tech created

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer requested review from nightkr and a team August 9, 2024 07:16
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 12395a0 Aug 9, 2024
20 checks passed
@sbernauer sbernauer deleted the fix/affinity-schema branch August 9, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants