Skip to content

feat: add DeploymentConditionBuilder #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 1, 2025
Merged

feat: add DeploymentConditionBuilder #993

merged 12 commits into from
Apr 1, 2025

Conversation

razvan
Copy link
Member

@razvan razvan commented Mar 31, 2025 •
edited
Loading

Description

Part of : stackabletech/spark-k8s-operator#284

This is a literal adaptation of the StatefulSetConditionBuilder because cleanup and consolidation are out of scope for the issue above.

Condition builders are used by SDP operators to monitor workloads and update stacklet status fields in a standardized way. This adds a condition builder for Deployments.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@razvan razvan self-assigned this Mar 31, 2025
@razvan razvan marked this pull request as ready for review March 31, 2025 10:17
@razvan razvan requested a review from a team March 31, 2025 10:17
@razvan razvan mentioned this pull request Mar 31, 2025
Closed
24 tasks
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Mar 31, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of suggestions

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 1, 2025
@razvan razvan requested a review from NickLarsenNZ April 1, 2025 09:00
@razvan razvan enabled auto-merge April 1, 2025 09:01
NickLarsenNZ
NickLarsenNZ previously approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, two more that I missed

@razvan razvan disabled auto-merge April 1, 2025 09:02
NickLarsenNZ
NickLarsenNZ approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Apr 1, 2025
Merged via the queue into main with commit 1815bc1 Apr 1, 2025
10 checks passed
@razvan razvan deleted the feat/deployment-condition branch April 1, 2025 09:11
@Techassi Techassi mentioned this pull request Apr 1, 2025
Merged
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Apr 14, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@razvan razvan

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razvan @NickLarsenNZ